Canary - windows tests failed because of path issues. #602
Conversation
| }); | ||
| }); | ||
|
|
||
| it('should respond with a 403 for standart user', function(done) { |
There was a problem hiding this comment.
If you could, please fix any typos and rebase this on top of canary as one or two commits, matching the commit style guidelines https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit. Thanks!
There was a problem hiding this comment.
Should I have different PR for each fixed issue? Or I can have one PR for more than one, as it is now?
There was a problem hiding this comment.
You can fix more than one issue in the PR, but each issue needs a commit message that would make sense in the changelog.
There was a problem hiding this comment.
So if I fix three issues I have to have exactly three commits in PR yes?
|
Changed to one commit, based on actual canary state. |
- change function assertOnlyFiles to use a different local variable from global module name - path. - show expected files when a test fails - use path.normalize before search in the array Closes #601
|
Rebased again and changed text. Tests ok. |
|
Merged. |
This PR fix
#601